The Cult of Clean Code (dev.to)
from costalfy@programming.dev to programming@programming.dev on 05 Feb 18:05
https://programming.dev/post/45268193

#programming

threaded - newest

Solumbran@lemmy.world on 05 Feb 19:32 next collapse

“The cult of understandable things”

Yeah ok bro, sure.

Who doesn’t like a gigantic shitty code that “just works” after all?

SamuraiBeandog@lemmy.world on 05 Feb 19:49 next collapse

This is an article by a person who doesn’t understand SOLID principles, talking about programmers who don’t understand SOLID principles.

MagicShel@lemmy.zip on 05 Feb 20:08 next collapse

I think this author has some points, but this is attacking the wrong thing.

Clean code is not the source of the problems described. If you see similar code and try to extract a common abstraction without further consideration, congrats, you’re thinking like a junior developer, and that’s not Clean Code’s fault, to pull one example.

Feyd@programming.dev on 05 Feb 20:25 collapse

The problem is that people recommend clean code to junior developers all the time. Clean Code is full of terrible advice and heuristics over critical thinking throughout, and is usually foisted on burgeoning juniors when they don’t know any better.

In other words, you’re correct that adherents of clean code are thinking like junior developers, because that’s what clean code tells you to do.

MagicShel@lemmy.zip on 05 Feb 20:58 collapse

That’s not my observation. I could flip it around and accuse the author of defending massive if/else chains because my experience is that anything that needs more than a handful of lines of code is either a complex mapper or a nightmare of failed Boolean algebra.

That doesn’t mean the bad code I’ve seen is OP’s fault. It means there’s a lot of shit programmers and adopting a particular style doesn’t fix it.

Feyd@programming.dev on 05 Feb 21:57 collapse

Then you’re just wrong. Clean Code directly tells you to make the mistakes the author of the article points out. The absurdity of the examples in the book should be evident enough.

Feyd@programming.dev on 05 Feb 20:27 next collapse

github.com/johnousterhout/aposd-vs-clean-code

Paragone@piefed.social on 05 Feb 20:46 next collapse

Saw this, a long while ago:

https://www.youtube.com/watch?v=tD5NrevFtbU

It measures clean code to wreck performance to terrible degree.

From the looks of it, in Molly Rocket’s view, clean code is an industry-wronging cult.

They’ve multiple videos on the subject, from different angles

https://www.youtube.com/results?search_query=molly+rocket+clean+code

Just putting this here for hopefully-more-accurate-view.

_ /\ _

resipsaloquitur@lemmy.world on 05 Feb 21:04 next collapse

You see two functions that look similar. Clean Code sirens start blaring in your head. You extract a common abstraction. You add parameters to handle the slight differences. Then more parameters. Then a config object. Then a strategy pattern because you’re a Real Engineer™.

I’ve watched dozens of hours of Uncle Bob videos (not by choice) and this isn’t what he advocates. At all.

This author has no clue what they’re talking about.

bitcrafter@programming.dev on 05 Feb 22:23 collapse

As someone who regularly has to deal with code that has been broken needlessly into smaller functions so that I have to constantly jump around to figure out what is going on, this really resonates with me.

The latest case was someone who took something that really only needed to be a single function and instead turned it into a class with a dozen tiny methods.